Skip to content

Bugfixes for XMDYNPhotonMatterAnalysis #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Bugfixes for XMDYNPhotonMatterAnalysis #248

wants to merge 5 commits into from

Conversation

@godot11
Copy link

@godot11 godot11 commented Sep 28, 2022

This fixes #246, #247, and an erroneous test in Analysis.XMDYNPhotonMatterAnalysis.XMDYNPhotonMatterAnalysis.

@godot11
Copy link
Author

godot11 commented Sep 29, 2022 •
edited
Loading

Please hold on with merging this one. pylab.find may not have been what I thought it was. It seems it was matplotlib.mlab.find which is simply

import numpy as np

def find(condition):
    res, = np.nonzero(np.ravel(condition))
    return res

and was removed in matplotlib versions >= 3.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Typo in DetectorGeometry.DetectorPanel documentation

1 participant

@godot11